[SPARK-36511][MINOR][SQL] Remove ColumnIOUtil#37529
Closed
panbingkun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-36511][MINOR][SQL] Remove ColumnIOUtil#37529panbingkun wants to merge 1 commit intoapache:masterfrom
panbingkun wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Aug 16, 2022
|
Can one of the admins verify this patch? |
Member
|
Merged to master |
| /** | ||
| * This is a workaround since methods below are not public in {@link ColumnIO}. | ||
| * | ||
| * TODO(SPARK-36511): we should remove this once PARQUET-2050 and PARQUET-2083 are released with |
Member
There was a problem hiding this comment.
This is not a minor. This should be removed with JIRA issue, SPARK-36511 .
Member
There was a problem hiding this comment.
To @panbingkun , please respect the code when you remove.
Apache Spark community uses IDed TODO like this for trace-ability and we had better respect them.
Member
|
Also, cc @sunchao since he is the issue reporter of SPARK-36511 . |
Member
|
OK fair enough can you file a JIRA? I can connect the dots |
Member
|
@srowen , the JIRA, SPARK-36511, was already filed and hard-coded in the removed part. Here, @panbingkun ignored it mistakenly. |
Member
|
Ah ok I'll connect it |
srowen
changed the title
Member
|
Thank you, @srowen . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aim to remove redundant ColumnIOUtil.
Why are the changes needed?
Complete todo.
reason: from parquet version 1.12.3, methods below are public
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.